Skip to content

better logging perf #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Mar 27, 2025
Merged

better logging perf #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions src/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ dotnet_diagnostic.CA1050.severity = none
# Use Literals Where Appropriate
dotnet_diagnostic.CA1802.severity = error

# Template should be a static expression
dotnet_diagnostic.CA2254.severity = error

# Potentially misleading parameter name in lambda or local function
resharper_all_underscore_local_parameter_name_highlighting = none

Expand Down
2 changes: 1 addition & 1 deletion src/Delta/DeltaExtensions_Shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ static void WriteNo304Header(HttpResponse response, string reason, LogLevel leve

if (logger.IsEnabled(level))
{
logger.Log(level, $"Delta {{path}}: No 304. {reason}", path);
logger.Log(level, "Delta {path}: No 304. {reason}", path, reason);
}
}

Expand Down
6 changes: 4 additions & 2 deletions ...teFunc=False_trueExecuteFunc=False_immutable=False_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -19,7 +18,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=False_trueExecuteFunc=False_immutable=False_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -23,7 +22,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=False_trueExecuteFunc=False_immutable=True_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -20,7 +19,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=False_trueExecuteFunc=False_immutable=True_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -24,7 +23,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=False_trueExecuteFunc=True_immutable=False_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -19,7 +18,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=False_trueExecuteFunc=True_immutable=False_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -23,7 +22,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=False_trueExecuteFunc=True_immutable=True_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -20,7 +19,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...ecuteFunc=False_trueExecuteFunc=True_immutable=True_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -24,7 +23,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=True_trueExecuteFunc=False_immutable=False_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -19,7 +18,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=True_trueExecuteFunc=False_immutable=False_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -23,7 +22,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=True_trueExecuteFunc=False_immutable=True_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -20,7 +19,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...ecuteFunc=True_trueExecuteFunc=False_immutable=True_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -24,7 +23,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...cuteFunc=True_trueExecuteFunc=True_immutable=False_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -19,7 +18,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...ecuteFunc=True_trueExecuteFunc=True_immutable=False_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -23,7 +22,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...ecuteFunc=True_trueExecuteFunc=True_immutable=True_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -20,7 +19,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...xecuteFunc=True_trueExecuteFunc=True_immutable=True_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -24,7 +23,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...teFunc=False_trueExecuteFunc=False_immutable=False_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -20,7 +19,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=False_trueExecuteFunc=False_immutable=False_requestCacheControl=True.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
Cache-Control: no-cache
}
},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -24,7 +23,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
6 changes: 4 additions & 2 deletions ...uteFunc=False_trueExecuteFunc=False_immutable=True_requestCacheControl=False.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
notModified: false,
context: {
Request: {},
IsAbortedRequested: false,
Response: {
StatusCode: OK,
Headers: {
Expand All @@ -21,7 +20,10 @@
path: /path
},
{
{OriginalFormat}: Delta {path}: No 304. Request Method=POST
reason: Request Method=POST
},
{
{OriginalFormat}: Delta {path}: No 304. {reason}
}
]
}
Expand Down
Loading