Canonicalize [Content_Types].xml Default/Override split#111
Merged
SimonCropp merged 1 commit intoJul 3, 2026
Merged
Conversation
System.IO.Packaging (via document.Clone, and Aspose's own writer) chooses which content type wins a per-extension <Default> vs a per-part <Override> through internal collection ordering. For an extension shared by several content types (notably xml: workbook/worksheet/styles/sharedStrings), that choice — and thus which parts become Overrides — was unstable across runs and producers. ContentTypesPatcher only sorted the entries, so the flap survived and Aspose.Cells xlsx serialized non-deterministically run-to-run. Canonicalize the split instead of just sorting: compute each part's effective content type, pick every extension's Default as its most-common content type (Ordinal tiebreak), and emit an explicit <Override> for each part that differs. This needs the full part list, so Convert now threads part names through to the patcher set. OPC-preserving: every part still resolves to its original content type (guarded by validator tests). Also drops a stale <Default Extension="psmdcp"> left behind when its part is removed.
SimonCropp
deleted the
Canonicalize-Content_Types].xml-Default/Override-split
branch
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.IO.Packaging (via document.Clone, and Aspose's own writer) chooses which content type wins a per-extension vs a per-part through internal collection ordering. For an extension shared by several content types (notably xml: workbook/worksheet/styles/sharedStrings), that choice — and thus which parts become Overrides — was unstable across runs and producers. ContentTypesPatcher only sorted the entries, so the flap survived and Aspose.Cells xlsx serialized non-deterministically run-to-run.
Canonicalize the split instead of just sorting: compute each part's effective content type, pick every extension's Default as its most-common content type (Ordinal tiebreak), and emit an explicit for each part that differs. This needs the full part list, so Convert now threads part names through to the patcher set. OPC-preserving: every part still resolves to its original content type (guarded by validator tests). Also drops a stale left behind when its part is removed.