Provide options to control shutdown#423
Merged
SimonCropp merged 1 commit intoSimonCropp:mainfrom Apr 30, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shutting down the database, there are some options provided by the underlying
LocalDBStopInstancefunction to control shutdown mode and timeout.Previously, the shutdown mode was hardcoded to dwFlag
0(uses theSHUTDOWNT-SQL statement), and a timeout of 10 seconds.Rather than hardcoding these, it would be useful if they could be controlled.
The only public API that currently calls into this is
SqlInstance.Cleanup- which does a shutdown and delete. For that code path, it makes more sense for the default behavior to shutdown as fast as possible by killing the process (dwFlag1). No need to have SQL cleanup if we're just going to delete the datafiles anyway.For the other code paths (used only in tests currently), I left the default as it was previously.
After this is incorporated, it might later make sense to figure out which tests should keep the database running and which should close it. Presently, running all tests leaves many orphaned processes.