Concurrent calls to one DocumentConverter race on shared parser state#80
Merged
SimonCropp merged 1 commit intomainfrom Apr 13, 2026
Conversation
DocumentConverter held a single DocumentParser instance field, but DocumentParser carries mutable fields it overwrites during Parse (theme colors, numbering tables, table style borders, default spacing). Two threads calling ConvertToImageData on the same converter would clobber each other's parse state, producing inconsistent output for the same input. Allocate a fresh DocumentParser per Parse call. Add a release-only regression test that interleaves two distinct inputs through one shared converter and asserts byte-identical output against a sequential baseline.
SimonCropp
deleted the
Concurrent-calls-to-one-DocumentConverter-race-on-shared-parser-state
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentConverter held a single DocumentParser instance field, but DocumentParser carries mutable fields it overwrites during Parse (theme colors, numbering tables, table style borders, default spacing). Two threads calling ConvertToImageData on the same converter would clobber
each other's parse state, producing inconsistent output for the same input.
Allocate a fresh DocumentParser per Parse call. Add a release-only regression test that interleaves two distinct inputs through one shared converter and asserts byte-identical output against a sequential baseline.