Honor w start/w end in table cell margin parsing#85
Merged
SimonCropp merged 6 commits intomainfrom Apr 20, 2026
Merged
Conversation
ParseTableCellMargin and ParseCellMargin only read the legacy <w:left>/<w:right> elements, ignoring the Office 2010+ <w:start>/<w:end> form. Writers emitting the modern form (e.g. Excelsior's WordTableRenderer) had their horizontal cell padding silently read as 0, so rendered output showed no left/right padding even though the docx declared it. Both methods now prefer StartMargin/EndMargin and fall back to the legacy TableCellLeftMargin/TableCellRightMargin (resp. LeftMargin/RightMargin). Made them internal static so Tests can exercise them directly, and added TableCellMarginParseTests covering both forms plus the precedence rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.