Skip to content

Support vs2022 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 2 commits into from
Oct 5, 2021
Merged

Support vs2022 #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65ee7fc
add support for VS 2022
SimonCropp Oct 5, 2021
fdc1a7a
Update Directory.Build.props
SimonCropp Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<LangVersion>latest</LangVersion>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>../key.snk</AssemblyOriginatorKeyFile>
<Version>1.8.0</Version>
<Version>1.9.0</Version>
<AssemblyVersion>1.0.0</AssemblyVersion>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<DebugType>embedded</DebugType>
Expand Down
8 changes: 0 additions & 8 deletions src/SetStartupProjects/Guard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ public static void AgainstNullAndEmpty(string value, string argumentName)
}
}

public static void AgainstNull(object value, string argumentName)
{
if (value == null)
{
throw new ArgumentNullException(argumentName);
}
}

public static void AgainstNonExistingFile(string file, string argumentName)
{
if (!File.Exists(file))
Expand Down
6 changes: 1 addition & 5 deletions src/SetStartupProjects/SetStartupProjects.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
<ItemGroup>
<PackageReference Include="ProjectDefaults" Version="1.0.58" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" Condition="$(Configuration) == 'Release'" />
<EmbeddedResource Include="Solution2012.suotemplate" />
<EmbeddedResource Include="Solution2013.suotemplate" />
<EmbeddedResource Include="Solution2015.suotemplate" />
<EmbeddedResource Include="Solution2017.suotemplate" />
<EmbeddedResource Include="Solution2019.suotemplate" />
<EmbeddedResource Include="*.suotemplate" />
<PackageReference Condition="$(Configuration) == 'Release'" Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<PackageReference Include="OpenMcdf" Version="2.2.1.9" />
</ItemGroup>
Expand Down
Binary file added src/SetStartupProjects/Solution2022.suotemplate
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion src/SetStartupProjects/StartProjectSuoCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ public class StartProjectSuoCreator
public void CreateForSolutionFile(string solutionFilePath, List<string> startupProjectGuids, VisualStudioVersions visualStudioVersions = VisualStudioVersions.All)
{
Guard.AgainstNullAndEmpty(solutionFilePath, nameof(solutionFilePath));
Guard.AgainstNull(startupProjectGuids, nameof(startupProjectGuids));
Guard.AgainstNonExistingFile(solutionFilePath, nameof(solutionFilePath));
if (startupProjectGuids.Count == 0)
{
Expand Down
8 changes: 6 additions & 2 deletions src/SetStartupProjects/VisualStudioVersions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ public enum VisualStudioVersions
/// </summary>
Vs2019 = 16,
/// <summary>
/// Target suo creation for Visual Studio versions 2012, 2013, 2015 and 2017.
/// Target suo creation for Visual Studio 2022.
/// </summary>
All = Vs2012 | Vs2013 | Vs2015 | Vs2017 | Vs2019,
Vs2022 = 32,
/// <summary>
/// Target suo creation for Visual Studio versions 2012, 2013, 2015, 2017, 2019, and 2022.
/// </summary>
All = Vs2012 | Vs2013 | Vs2015 | Vs2017 | Vs2019 | Vs2022,
}
}