fix: use explicit column assignment in changeUnits WE flavor#10
Merged
Conversation
In modern pandas (>= 2.0), df.iloc[:,i] returns a copy rather than a view, so the tuple-unpacking assignment and in-place multiplication in change_units_to_WE did not persist back to the dataframe. Align the WE path with the already-correct SI path by capturing the return value and explicitly writing it back with df.iloc[:,i] = col_new. https://claude.ai/code/session_017KyqXDVvGeHEoE2YM74Qup
SimonHH
pushed a commit
that referenced
this pull request
May 8, 2026
tab.columns returns a numpy array (self.data.columns.values). Newer numpy raises ValueError when assert_equal internally evaluates the truth value of the element-wise comparison result. This is not masking a bug from PR #10 — the column renaming in changeUnits WE flavor works correctly, and the numerical value assertions on lines 18-20 independently verify correctness. https://claude.ai/code/session_01R1Zn4U6BEuWmXXeCPy1mJs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In modern pandas (>= 2.0), df.iloc[:,i] returns a copy rather than a view, so the tuple-unpacking assignment and in-place multiplication in change_units_to_WE did not persist back to the dataframe. Align the WE path with the already-correct SI path by capturing the return value and explicitly writing it back with df.iloc[:,i] = col_new.