fix: use ms precision for Time-based resampler to support pandas 2.2+#9
Merged
Merged
Conversation
In pandas 2.2+, pd.to_timedelta(x, unit='s') creates a timedelta64[s] index. Resampling at sub-second intervals then fails because the bin endpoint (e.g. 500ms) cannot be losslessly cast to seconds precision. Switch to milliseconds for both the time index and the resample offset string, which gives sufficient precision for sub-second intervals and removes the now-unnecessary pandas version-check workaround. https://claude.ai/code/session_01WvnvMa5iWDmswWc7PwbZNQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pandas 2.2+, pd.to_timedelta(x, unit='s') creates a timedelta64[s] index. Resampling at sub-second intervals then fails because the bin endpoint (e.g. 500ms) cannot be losslessly cast to seconds precision.
Switch to milliseconds for both the time index and the resample offset string, which gives sufficient precision for sub-second intervals and removes the now-unnecessary pandas version-check workaround.