Make DynamicsModelTpl separate from StageFunctionTpl class hierarchy
#229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifoldFR
force-pushed
the
topic/remove-dynamics-from-function-hierarchy
branch
2 times, most recently
from
7b67c8d to
46686e5
Compare
arity of StageFunction calls + Turn DynamicsDataTpl into its own class (with own hierarchy) + Remove StageFunctionDataTpl::Jy_, Hxy_, Huy_, Hyy_... + [Python] Update bindings accordingly - add PyDynamics<> templated trampoline class
+ Fix "Data" typedefs for finite difference classes
…dynamics and functions
Follow-up commit for Python tests (VII)
ManifoldFR
force-pushed
the
topic/remove-dynamics-from-function-hierarchy
branch
from
46686e5 to
5144c30
Compare
edantec
requested changes
Oct 10, 2024
Collaborator
edantec
left a comment
edantec
left a comment
There was a problem hiding this comment.
There are one or two details that bother me bu otherwise good job!
edantec
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
clone.hpp,version.hppheadersMerge after #226
Progress on #208 and #79