Skip to content

Drop support for php 5.4 and 5.5 - #42

Merged
cmodijk merged 1 commit into
masterfrom
php-56
Jun 12, 2017
Merged

Drop support for php 5.4 and 5.5#42
cmodijk merged 1 commit into
masterfrom
php-56

Conversation

@cmodijk

@cmodijk cmodijk commented May 2, 2017

Copy link
Copy Markdown
Member
  • Drop support for php 5.4 and 5.5
  • Add travis for php 7.1
  • Changed symfony version to 2.7 and 3.2

More details SimpleBus/message-bus#68

@codecov

codecov Bot commented May 2, 2017

Copy link
Copy Markdown

Codecov Report

Merging #42 into master will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage    90.4%   89.45%   -0.96%     
==========================================
  Files          17       17              
  Lines         271      275       +4     
==========================================
+ Hits          245      246       +1     
- Misses         26       29       +3
Impacted Files Coverage Δ
src/RequiresOtherBundles.php 50% <0%> (-4.55%) ⬇️
...c/DependencyInjection/Compiler/CollectServices.php 46.15% <0%> (-3.85%) ⬇️
...DependencyInjection/Compiler/AddMiddlewareTags.php 72.41% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347c884...bc211b7. Read the comment docs.

Comment thread .travis.yml
- php: 7.1
env: SYMFONY_VERSION="2.7.*"
- php: 5.6
env: SYMFONY_VERSION="2.8.*@dev"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep 2.8 as it is an LTS release

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh Yes, we should i will add this again tnx

Add travis for php 7.1
Changed symfony version to 2.7 and 3.2
Changed the single pipe | to double to be inline with the rest of the repositorie
@cmodijk
cmodijk merged commit c5752d4 into master Jun 12, 2017
@cmodijk
cmodijk deleted the php-56 branch June 12, 2017 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants