cmake: Set CMAKE_BUILD_TYPE to Release if none was specified#26
Merged
Conversation
Member
|
Thank you for the patch! I believe that scikit-build default sets the |
blowekamp
reviewed
Feb 6, 2017
| mark_as_advanced(CMAKE_BUILD_TYPE) | ||
| # Set the possible values of build type for cmake-gui | ||
| set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug" "Release" | ||
| "MinSizeRel" "RelWithDebInfo") |
Member
There was a problem hiding this comment.
Currently the project has the languages set to NONE. If this was C++ would we not get these default properties?
blowekamp
force-pushed
the
explicitly-set-build-type
branch
from
32ec12b to
073fcdc
Compare
Member
|
The SimpleITK-python was missing ep_common_cmake_cache_args. Looks good to me now |
Collaborator
Author
No. It is the responsibility of the build system developer to propagate them.
I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.