[2.1 & 3.0]: Users cannot turn off word censoring when admin allows them to

[Oldiesmann]

Basic Information

When the admin enables the option to allow users to turn off word censoring, that option doesn't show up in the user's profile, whether looking at the options as an admin or as the user themselves.

Steps to reproduce

1. Go to Admin -> Forum -> Posts and Topics -> Censored Words
2. Check the box next to the "Allow users to disable word censoring" option and save the settings.
3. Go to the look and layout section of any user's profile

Expected result

The option to turn off word censoring should be there

Actual result

No such option appears.

Version/Git revision

2.1.6

Database Engine

All

Database Version

No response

PHP Version

No response

Logs

Additional Information

In 2.1, the code to display the option is still there. I haven't checked 3.0 yet but I would assume similar code exists in that version as well.

SMF/Sources/Profile-Modify.php

Lines 556 to 571 in a0bb207

	'theme_settings' => array(
	'type' => 'callback',
	'callback_func' => 'theme_settings',
	'permission' => 'profile_extra',
	'is_dummy' => true,
	'preload' => function() use (&$context, $user_info, $modSettings)
	{
	loadLanguage('Settings');
	$context['allow_no_censored'] = false;
	if ($user_info['is_admin'] || $context['user']['is_owner'])
	$context['allow_no_censored'] = !empty($modSettings['allow_no_censored']);
	return true;
	},
	),

[jdarwood007]

Good news, you broke it @Oldiesmann

f8cff26 broke it and then 6caed7a restored it. You broke it again in 3618f6d, and nobody noticed it.

The good news is, fixing it is simple. Just need to add to Settings template for template_options:

		array(
			'id' => 'show_no_censored',
			'label' => $txt['show_no_censored'],
			'default' => false,
		),

[Oldiesmann]

Whoops. The fact that nobody's noticed in over a decade means it must not be used much. I'll commit the fix when I get home from work tonight

[jdarwood007]

Already had it in the pipeline. Just took a bit to fix for 3.0 because of #8830