[3.0|2.1]: Auto saving drafts not working for normal users in the full post editor

[isaak654]

Basic Information

https://www.simplemachines.org/community/index.php?topic=592325.0

Steps to reproduce

1. Ensure "Enable the saving of Post drafts" is enabled in the draft settings by the admin.
2. Confirm that the user group permissions are set to allow normal members to save drafts.
3. Log in as a normal user (non-admin).
4. Write a post using the full "normal" reply button in the editor.

Expected result

Auto-saving drafts should work for non-admin users in the full post editor.

Version/Git revision

2.1.6

[jdarwood007]

I can't reproduce. As a regular user, when I go to a board and start writing a post. The "Save Draft" button is there and works.

Is this for the auto-saving draft feature? As that seems to be broken for me for both admin and user. I don't see network traffic indicating its saving.

[sbulen]

The thread describes it as the timed auto save feature. OK in quick reply, but not in reply. Worked ok in 2.1.4, & early 2.1.5 beta.

[jdarwood007]

Ok, I can reproduce that auto-saving doesn't work. Affecting both 2.1 and 3.0.

[jdarwood007]

SMF/Sources/Post.php

Line 1186 in e6ea996

$context['drafts_autosave'] = !empty($context['drafts_save']) && !empty($modSettings['drafts_autosave_enabled']) && allowedTo('post_autosave_draft') && !empty($options['drafts_autosave_enabled']);

There is no post_autosave_draft permission; however, we do set it as an illegal guest permission.

In #1808 the permission was removed, but failed to update Post.php

I think the simple, quick fix for 2.1 is to just update the check in Post.php. The proper fix is to remove it all the way (a few leftover references exist).

[jdarwood007]

Another note, I can't explain why it worked for you in .4. The only thing I can think of is permissions cleaned up somehow? The old permission was still in the system somewhere, and it is no longer there.