[3.0] Fix invalid timezone#9075
Merged
jdarwood007 merged 1 commit intoSimpleMachines:release-3.0from Jan 24, 2026
Merged
Conversation
The main issue is the user has an invalid timezone in their profile. Doing a check for an empty profile is simple, but a garbage entry is another issue. https://www.php.net/manual/en/datetimezone.construct.php According to the documentation an invalid timezone throws an error. Our code is assuming in many places that a valid time zone will be returned. The exception is not being handled Create a wrapper and attempt to fallback the forum default time zone if we fail to get a valid user time zone Anywhere we use UTC, I ignored using the wrapper. Fixes SimpleMachines#9037
Member
|
SMF\TimeZone::create() should return an instance of SMF\TimeZone, not \DateTimeZone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue is the user has an invalid timezone in their profile. Doing a check for an empty profile is simple, but a garbage entry is another issue.
https://www.php.net/manual/en/datetimezone.construct.php
According to the documentation an invalid timezone throws an error. Our code is assuming in many places that a valid time zone will be returned. The exception is not being handled
Create a wrapper and attempt to fallback the forum default time zone if we fail to get a valid user time zone Anywhere we use UTC, I ignored using the wrapper.
Fixes #9037