Retain attachment dir indexes #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the repair_settings with attachments directories with non continous indexes, the indexes was reset to a continous index. If one of the reindexed directories was selected as current attachment directory, it would point to the wrong, or non existing attachment directory index. Fix this by passing and using the current indexes. Non coninous indexes can happen if an attachment directory is removed that is not the last. Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
Contributor
|
I was able to confirm the bug using 2.0. Yep, if there was a gap, it renumbered, even if you didn't change anything... Once you hit SAVE. I started testing all 3 of these together (#53 , #54 , #55 ) in SMF 2.0 EDIT: Something funky was cached somewhere. Everything looks good! |
sbulen
approved these changes
Jan 10, 2022
Contributor
sbulen
left a comment
sbulen
left a comment
There was a problem hiding this comment.
LGTM - tested under both 2.0 & 2.1.
Contributor
|
Also confirmed nothing got broken under 1.x... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the repair_settings with attachments directories
with non continous indexes, the indexes was reset to a continous
index. If one of the reindexed directories was selected as current
attachment directory, it would point to the wrong, or non existing
attachment directory index. Fix this by passing and using the current
indexes.
Non coninous indexes can happen if an attachment directory is removed
that is not the last.
Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com