Regular bind service instead of singleton.#75
Merged
SimplyCorey merged 1 commit intoSimpleSoftwareIO:developfrom Nov 26, 2017
Merged
Regular bind service instead of singleton.#75SimplyCorey merged 1 commit intoSimpleSoftwareIO:developfrom
SimplyCorey merged 1 commit intoSimpleSoftwareIO:developfrom
Conversation
Binding as a regular service instead of singleton avoids issues with the generation of QRCodes multiple times within the same execution
Member
|
@ablunier Which issues were you experiencing? |
Contributor
Author
|
@SimplyCorey when I invoque the generator more than once in the same PHP execution thread, it only generates the first QRCode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding as a regular service instead of singleton avoids issues with the generation of QRCodes multiple times within the same execution thread