Skip to content

Add note about params disjointness in mtl_backward#207

Merged
ValerianRey merged 2 commits intomainfrom
add-note-about-params-in-mtl-backward
Dec 10, 2024
Merged

Add note about params disjointness in mtl_backward#207
ValerianRey merged 2 commits intomainfrom
add-note-about-params-in-mtl-backward

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Dec 10, 2024 •
edited
Loading

  • Add test_mtl_backward_default_shared_params_overlap_with_default_tasks_params
  • Add note asking for shared_params and tasks_params to be disjoint

@ValerianRey ValerianRey added this to the Release v0.3.0 milestone Dec 10, 2024
@ValerianRey ValerianRey added cc: docs Conventional commit type for changes to the documentation. cc: test Conventional commit type for changes to tests. labels Dec 10, 2024
@ValerianRey ValerianRey self-assigned this Dec 10, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/autojac/mtl_backward.py 100.00% <ø> (ø)

@ValerianRey ValerianRey changed the title add note about params in mtl backward Add note about params in mtl backward Dec 10, 2024
@ValerianRey ValerianRey changed the title Add note about params in mtl backward Add note about params disjointness in mtl_backward Dec 10, 2024
@ValerianRey ValerianRey merged commit 085c990 into main Dec 10, 2024
@ValerianRey ValerianRey deleted the add-note-about-params-in-mtl-backward branch December 10, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PierreQuinton PierreQuinton Awaiting requested review from PierreQuinton PierreQuinton is a code owner

Assignees

@ValerianRey ValerianRey

Labels

cc: docs Conventional commit type for changes to the documentation. cc: test Conventional commit type for changes to tests.

Projects

None yet

Milestone

Release v0.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@ValerianRey