Skip to content

Simplify _get_leaf_tensors#209

Merged
ValerianRey merged 2 commits intomainfrom
fix-get-leaf-tensors
Dec 10, 2024
Merged

Simplify _get_leaf_tensors#209
ValerianRey merged 2 commits intomainfrom
fix-get-leaf-tensors

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Dec 10, 2024

  • Change it to only work with tensors and excluded that have a grad_fn
  • Stop making it exclude the excluded tensors themselves (only exclude their grad_fn from the graph traversal)

@ValerianRey ValerianRey added this to the Release v0.3.0 milestone Dec 10, 2024
@ValerianRey ValerianRey added the cc: feat Conventional commit type for new features. label Dec 10, 2024
@ValerianRey ValerianRey self-assigned this Dec 10, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/autojac/_utils.py 100.00% <100.00%> (ø)

@ValerianRey ValerianRey changed the title Change _get_leaf_tensors to only work on tensors with a grad_fn Simplify _get_leaf_tensors Dec 10, 2024
@ValerianRey ValerianRey merged commit 69f56f6 into main Dec 10, 2024
@ValerianRey ValerianRey deleted the fix-get-leaf-tensors branch December 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: feat Conventional commit type for new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant