Skip to content

Remove exception re-raising with svd #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValerianRey merged 1 commit into from
Mar 25, 2025
Merged

Remove exception re-raising with svd #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/torchjd/aggregation/_gramian_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import torch
from torch import Tensor
from torch.linalg import LinAlgError


def _compute_gramian(matrix: Tensor) -> Tensor:
Expand Down Expand Up @@ -33,13 +32,7 @@ def _compute_normalized_gramian(matrix: Tensor, eps: float) -> Tensor:
:math:`n` through the SVD algorithm which is efficient, therefore this is rather fast.
"""

try:
left_unitary_matrix, singular_values, _ = torch.linalg.svd(matrix, full_matrices=False)
except LinAlgError as error: # Not sure if this can happen
raise ValueError(
f"Unexpected failure of the svd computation on matrix {matrix}. Please open an "
"issue on https://github.com/TorchJD/torchjd/issues and paste this error message in it."
) from error
left_unitary_matrix, singular_values, _ = torch.linalg.svd(matrix, full_matrices=False)
max_singular_value = torch.max(singular_values)
if max_singular_value < eps:
scaled_singular_values = torch.zeros_like(singular_values)
Expand Down