Skip to content

Add test_stack_different_required_keys#274

Merged
ValerianRey merged 1 commit intomainfrom
improve-stack-testing
Mar 26, 2025
Merged

Add test_stack_different_required_keys#274
ValerianRey merged 1 commit intomainfrom
improve-stack-testing

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

At first, I wanted to make this test in test_stack.py, but actually, it depends on other transforms: we can't specify required keys with the FakeGradientsTransform defined in test_stack.py, and I think test files of autojac currently only depend on the transforms that they test, except for test_interactions.py which contains tests combining multiple transforms.
The alternative would have been to create another fake transform in test_stack.py, for instance one that would require some keys but that would not produce any output (kind of the opposite of the FakeGradientsTransform). I'm not sure it's worth the effort, and I like having this test apply on a real transform like Grad, so I prefer what I did.

@ValerianRey ValerianRey self-assigned this Mar 26, 2025
@ValerianRey ValerianRey added cc: test Conventional commit type for changes to tests. package: autojac labels Mar 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValerianRey ValerianRey force-pushed the improve-stack-testing branch from 9fbd3d3 to 4163499 Compare March 26, 2025 00:57
@ValerianRey ValerianRey merged commit 1bb5c35 into main Mar 26, 2025
14 checks passed
@ValerianRey ValerianRey deleted the improve-stack-testing branch March 26, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: test Conventional commit type for changes to tests. package: autojac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants