Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
This reverts commit d14daa6.
PierreQuinton
approved these changes
Apr 8, 2025
Contributor
PierreQuinton
left a comment
There was a problem hiding this comment.
LGTM. Just wondering, should we change deploy to main to deploy to latest? If so we would have latest, stable and one for each version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for documentation build preview in PRs, because we cannot have a satisfying solution with GitHub Pages that will also work with forks.
It also fixes a security issue of having the
DOCUMENTATION_DEPLOY_KEYbe a repository-wide secret not protected by any environment. To avoid this, it uses instead the newPROD_DOCUMENTATION_DEPLOY_KEY, which is an environment secret of the newprod-documentationenvironment, tied to the main branch or the version tags. This private key matches the new public deploy keyPROD_DOCUMENTATION_DEPLOY_KEYof TorchJD/documentation, that has write access to it.Lastly, this PR improves the name of the job by using the dedicated
namefield and renames themainfolder tolatest.Short-term future steps after merging this:
DOCUMENTATION_DEPLOY_KEYprivate key from TorchJD/torchjd and the associated public key from TorchJD/documentation.Long-term future steps: