Skip to content

Make some aggregator dependencies optional#327

Merged
ValerianRey merged 7 commits intomainfrom
add-optional-dependencies
Apr 28, 2025
Merged

Make some aggregator dependencies optional#327
ValerianRey merged 7 commits intomainfrom
add-optional-dependencies

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Apr 27, 2025

  • Add optional dependency groups nash_mtl, cagrad and full
  • Remove cxvpy and ecos from the default dependencies
  • Change tests.yml to also install the full dependency group
  • Update documentation about how to install torchjd in README.md, installation.md, cagrad.py and nash_mtl.py
  • Add changelog entry

@ValerianRey ValerianRey added cc: chore Conventional commit type for changes to some configuration files of the project. breaking-change This PR introduces a breaking change. labels Apr 27, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/aggregation/cagrad.py 100.00% <ø> (ø)
src/torchjd/aggregation/nash_mtl.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless you want to find the relaxed version for cvxpy for nasth-mtl without cagrad, but I think this is a waste of time.

@ValerianRey ValerianRey changed the title Make some dependencies optional Make some aggregator dependencies optional Apr 28, 2025
@ValerianRey ValerianRey merged commit 24e9438 into main Apr 28, 2025
15 checks passed
@ValerianRey ValerianRey deleted the add-optional-dependencies branch April 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This PR introduces a breaking change. cc: chore Conventional commit type for changes to some configuration files of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants