Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
b2e541d to
95f5907
Compare
c6d2003 to
8de8467
Compare
* The former is deprecated according to our new build-system setuptools
Contributor
Author
|
For the release.yml action, we have no way to test (unless we want to go through testing with the testpypi index, but it would be quite time-consuming). But it really seems to be very similar to how we publish with pdm (except that we have to add a step to build as well). So I would say that what I did will very probably work (90%). |
PierreQuinton
approved these changes
Apr 29, 2025
Contributor
Author
See my comment at the top of the PR (I tried but it requires to track uv.lock with git) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically, this should only affect contributors and CI.
The main goal is to reduce the duration of the CI checks. They now seem much shorter, (< 80 sec for the slowest I think instead of about 240 seconds with pdm). This could probably be reduced even further by using caching, to maybe < 40 sec (which would be really nice).
TODO:
Maybe in future PR:
uv.lock=> It would require to have a uv.lock file tracked by git and updated by the CI, which will be more time consumed than saved IMO.