Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
May 28, 2025
Contributor
Author
|
Note that from arena, installing this branch (add-py-typed) of torchjd seems to fix the issue: => No more [import-untyped] error. So it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using mypy, I had an issue with qpsolvers:
I never knew about this, but PEP 561 asks package maintainers to add a
py.typedfile in their topmost package to indicate that the package's interface is type-hinted. Mypy will read this and analyze it only if apy.typedmarker is present, or if the--follow-untyped-importsflag is provided.So we actually have the same problem with torchjd itself! To verify this, I tried running mypy from arena, and I got the following error:
For now, when building the
torchjdpackage, everything (included thispy.typedfile) is included, so I think we don't have to change anything else (this seems to be the case since setuptools 69.0.