Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Closed
PierreQuinton
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type hint when it's not possible for mypy to infer them: when an empty structure is created before being filled (note that mypy is able to infer the type in this case but only when the structure is filled with simple .append calls - here we use dict union or our add function), and when a Select transform is created.
The thing is that when creating a Select transform, there is no way for mypy to know whether it's a selection of Gradients, of Jacobians, or of something else. Also, we can directly specify the type of the Select transform right after the class name when instantiating it, which is what I used there.
Note that this is required to avoid some mypy errors.