Skip to content

Ignore type error in get_leaf_tensors#371

Merged
ValerianRey merged 2 commits intomainfrom
ignore-get-leaf-tensors-type-error
Jun 2, 2025
Merged

Ignore type error in get_leaf_tensors#371
ValerianRey merged 2 commits intomainfrom
ignore-get-leaf-tensors-type-error

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

Comment should explain the PR well enough. Note that as opposed to #370, this ignores an error that is a result of torch rather than a result of our implementation.

@ValerianRey ValerianRey added the cc: style Conventional commit type for minor style changes. label May 29, 2025
@ValerianRey ValerianRey self-assigned this May 29, 2025
@ValerianRey ValerianRey added the cc: style Conventional commit type for minor style changes. label May 29, 2025
@ValerianRey ValerianRey mentioned this pull request May 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/torchjd/_autojac/_utils.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValerianRey ValerianRey changed the title Ignore type error in get_leaf_tensors and add comment Ignore type error in get_leaf_tensors May 29, 2025
@ValerianRey ValerianRey mentioned this pull request May 29, 2025
1 task
@ValerianRey ValerianRey merged commit 4b67d1d into main Jun 2, 2025
15 of 16 checks passed
@ValerianRey ValerianRey deleted the ignore-get-leaf-tensors-type-error branch June 2, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: style Conventional commit type for minor style changes. package: autojac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants