Merged
Conversation
ValerianRey
added
package: autojac
cc: refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Closed
PierreQuinton
approved these changes
Jun 3, 2025
ValerianRey
force-pushed
the
remove-tensor-dicts
branch
from
c50e9af to
897e80c
Compare
Contributor
Author
|
This makes the creation of transforms a bit harder, and more risky, but at the same time less verbose. I think it's fine, and it leaves the door open for a better solution if we ever have time to spend on that again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #376
This is an alternative to #379 + #380, as it makes mypy happy, it is correct and it is fast. It is more error-prone when writing transforms though, but we rarely write transforms, so we could just be extra careful when this happens.
TODO: