refactor(autogram): Use GramianComputers working on modules#453
Merged
ValerianRey merged 34 commits intomainfrom Oct 14, 2025
Merged
refactor(autogram): Use GramianComputers working on modules#453ValerianRey merged 34 commits intomainfrom
GramianComputers working on modules#453ValerianRey merged 34 commits intomainfrom
Conversation
PierreQuinton
added
cc: refactor
PierreQuinton
changed the base branch from
main
to
accumulate-jacobian-returns-jacobians
ValerianRey
reviewed
Oct 12, 2025
ValerianRey
reviewed
Oct 12, 2025
Base automatically changed from
accumulate-jacobian-returns-jacobians
to
main
October 12, 2025 22:23
ValerianRey
force-pushed
the
gramian-accumulator-handles-modules
branch
from
fc8e14d to
41d3b0b
Compare
Contributor
|
I think I really like this. It's like we fully commit to a module-based engine with this, which has probably a few small disadvantages (like dropping support for InterModuleParamReuse) but makes things simpler and cleaner IMO. Things like InterModuleParamReuse should only be supported with a Node-based engine probably. |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
…cobian product but rather generalized Jacobian.
…leJacobians`, `JacobianAccumulator` and `GramianAccumulator` accordingly.
…t is considered to be `None` for all the PyTree.
* This makes us able to instantiate them outside of the hook, and thus to potentially give them a state.
* This will allow us to keep a reference to them in the engine and to reset them as needed when we add a state for them
This comment was marked as resolved.
This comment was marked as resolved.
PierreQuinton
commented
Oct 14, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ValerianRey
approved these changes
Oct 14, 2025
ValerianRey
changed the title
GramianAccumulator track paths to Modules rather than parametersGramianComputers working on module level
ValerianRey
changed the title
GramianComputers working on module levelGramianComputers working on modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.