Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
ValerianRey
changed the title
ShapedModules
ValerianRey
force-pushed
the
remove-trivial-shaped-modules
branch
2 times, most recently
from
0f4b69d to
e7250a9
Compare
* Add support for RNN, BatchNorm2d and InstanceNorm2d in get_in_out_shapes * Remove WithRNN, WithBatchNorm and WithModuleTrackingRunningStats - use simple factories instead * Whenever a ShapedModule is simply a wrapper around a single nn.Module, we can replace it by a line in get_in_out_shapes and make a factory directly out of the nn.Module. It's not strictly equivalent (because now the module isn't wrapped), but it's closer to what a user would do.
ValerianRey
force-pushed
the
remove-trivial-shaped-modules
branch
from
e7250a9 to
5fec5f7
Compare
Contributor
Author
|
@PierreQuinton FYI, this is how you can test any nn.Module now. |
ValerianRey
added a commit
that referenced
this pull request
Oct 20, 2025
* Add support for RNN, BatchNorm2d and InstanceNorm2d in get_in_out_shapes * Remove WithRNN, WithBatchNorm and WithModuleTrackingRunningStats - use simple factories instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a ShapedModule is simply a wrapper around a single nn.Module, we can replace it by a line in get_in_out_shapes and make a factory directly out of the nn.Module. It's not strictly equivalent (because now the module isn't wrapped), but it's closer to what a user would do.