Skip to content

docs: Fix weighting hook registration (#492) #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValerianRey merged 2 commits into from
Dec 20, 2025
Merged

docs: Fix weighting hook registration (#492) #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb425a
doc: Fix weighting hook registration
mattbuot Dec 20, 2025
b2241e8
Merge branch 'main' into 492-example-showing-how-to-register-weightin…
mattbuot Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/examples/monitoring.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ they have a negative inner product).
optimizer = SGD(params, lr=0.1)
aggregator = UPGrad()

aggregator.weighting.register_forward_hook(print_weights)
aggregator.weighting.weighting.register_forward_hook(print_weights)
aggregator.register_forward_hook(print_gd_similarity)

inputs = torch.randn(8, 16, 10) # 8 batches of 16 random input vectors of length 10
Expand Down
2 changes: 1 addition & 1 deletion tests/doc/test_rst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def print_gd_similarity(_, inputs: tuple[torch.Tensor, ...], aggregation: torch.
optimizer = SGD(params, lr=0.1)
aggregator = UPGrad()

aggregator.weighting.register_forward_hook(print_weights)
aggregator.weighting.weighting.register_forward_hook(print_weights)
aggregator.register_forward_hook(print_gd_similarity)

inputs = torch.randn(8, 16, 10) # 8 batches of 16 random input vectors of length 10
Expand Down
Loading