refactor(autojac): Stop cloning in Accumulate#511
Merged
ValerianRey merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows our discussion on whether we should clone or not in Accumulate. The change alone made a test fail, but this test was precisely a very weird usage of Accumulate, where the same tensor dict is accumulated multiple times. So I also changed the test. I think this could have a benefit on memory usage, but not sure if this benefit can happen when memory is at its peak usage (at this point, the Jacobian should be aggregated already, so not in memory anymore, so maybe we don't care that much about an extra gradient in memory there until the completion of this function). But I remember correctly, we used to have some out of memory errors during the Accumulate call, so I might be wrong about this.
Anyway, it seems like a strict improvement.