refactor(linalg): Make Matrix and PSDMatrix public#673
Open
ValerianRey wants to merge 8 commits intomainfrom
Open
refactor(linalg): Make Matrix and PSDMatrix public#673ValerianRey wants to merge 8 commits intomainfrom
ValerianRey wants to merge 8 commits intomainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Weighting[Matrix]/Weighting[PSDMatrix] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
We either need to have both |
…as private bases These private intermediate classes give the `__call__` method a properly named parameter (`matrix` or `gramian`) instead of the generic `stat`, improving documentation for all concrete weighting subclasses. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oval and Matrix/PSDMatrix addition Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…the codebase Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torchjd.linalgpackage exposingMatrixandPSDMatrix(the rest of_linalgstays protected)MatrixWeightingandGramianWeightingprotected. These classes are still used to specify the docstring of the__call__methods of the aggregators, but the user only sees those aggregators asWeighting[Matrix]andWeighting[PSDMatrix], respectively. TheMatrixWeightingandGramianWeightingclasses really just bring updated docstrings, that's all.MatrixandPSDMatrixwith Jacobian and Gramian examples; adds Sphinx documentation under a new linalg section in the API Reference