fix: cargo upgrade script and Rust dependency updates#257
Merged
SimplicityGuy merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
Script fix (scripts/update-project.sh):
- Fix cargo-upgrade invocation: use "cargo upgrade" (subcommand) instead of
"cargo-upgrade" (direct binary) — the binary does not accept flags like
--incompatible when called directly, causing silent failure
- Change 2>/dev/null to 2>&1 so errors are visible instead of swallowed
- Use boolean flag for detection, invoke via cargo subcommand for execution
Dependency updates (via cargo upgrade --incompatible allow):
- sha2: 0.10 → 0.11 (breaking: finalize() output no longer implements LowerHex)
- tokio: 1.49 → 1.50
- lapin: 4.0 → 4.4
- clap: 4.5 → 4.6
- tempfile: 3.25 → 3.27
- proptest: 1.10 → 1.11
- serial_test: 3.3.1 → 3.4.0
sha2 0.11 migration:
- Replace format!("{:x}", hasher.finalize()) with hex::encode(hasher.finalize())
across all 9 call sites in 6 source files and 3 test files
- Add hex import to test files that use sha2 directly
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
E2E Coverage (chromium)
|
Contributor
E2E Coverage (firefox)
|
Contributor
E2E Coverage (webkit)
|
Contributor
E2E Coverage (webkit - iPhone 15)
|
Contributor
E2E Coverage (webkit - iPad Pro 11)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-project.sh --majorwas silently failing to upgrade Rust dependencies because it invokedcargo-upgrade(binary) instead ofcargo upgrade(subcommand) — the binary doesn't accept--incompatibleflags when called directly, and2>/dev/nullhid the errorfinalize()output no longer implementsLowerHex, so replaced allformat!("{:x}", hasher.finalize())withhex::encode(hasher.finalize())across 9 call sitesRust dependency bumps
Test plan
cargo check— compiles cleanlycargo test— 14 passedcargo clippy -- -D warnings— no warningscargo fmt— formattedshellcheck+shfmt— script passes🤖 Generated with Claude Code