Conversation
ylebre
reviewed
Jun 17, 2025
| let replacements = { | ||
| "componentPreview" : data, | ||
| "actions" : editor.transformers.simplyPreviewActions.render(editor.pageData.app.actions ?? []), | ||
| "shortcuts" : editor.transformers.simplyPreviewActions.render(editor.pageData.app.shortcuts ?? []), |
Contributor
There was a problem hiding this comment.
This should be simplyPreviewShortcuts.render
ylebre
reviewed
Jun 17, 2025
ylebre
reviewed
Jun 17, 2025
ylebre
requested changes
Jun 17, 2025
Contributor
ylebre
left a comment
ylebre
left a comment
There was a problem hiding this comment.
Good start! I've added a few pointers where another transformer should be called, and I do not see that transformer in the code yet.
The data-format component also has to receive extra handling for shortcuts in order to save/load them using the 'new' format (to make each shortcut into their own js file) - this is similar to the actions.
ylebre
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to add keyboard shortcuts.