[MS-1340] MFID: adding validation for manual credential entry

[alexandr-simprints]

JIRA ticket
Will be released in: 2025.4.1

Notable changes

• Edited credential can only be saved if it has valid format
• State object in ViewModel now reflects the UI edit state so that it is preserved during the configuration change (i.e.: rotation)
• Continue button is available only if checkbox is selected and the format of the current displayed credential is correct

Additional work checklist

• Effect on other features and security has been considered

[Copilot]

Pull request overview

This PR adds validation for manual credential entry in the Multi-Factor ID (MFID) feature. It ensures that credentials can only be saved when they match the expected format for their type (Ghana ID Card, NHIS Card, or QR Code), and preserves the editing state across configuration changes like screen rotation.

Changes:

• Added format validation for manually entered credentials using dedicated use cases for Ghana ID Card and NHIS Card patterns
• Introduced isEditingCredential flag in SearchCredentialState to track and persist editing state across configuration changes
• Updated UI to enable/disable the edit/save icon based on credential format validity
• Continue button is now disabled while editing to prevent proceeding with unsaved changes
• Added color selector resource to visually indicate disabled state for the save icon

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
ExternalCredentialSearchViewModelTest.kt	Added mock dependencies for Ghana ID and NHIS card validation use cases
ic_done.xml	Changed hardcoded color to color resource reference to support disabled state
ic_edit_color.xml	New color selector defining colors for enabled and disabled states
SearchCredentialState.kt	Added isEditingCredential boolean field to preserve editing state
ExternalCredentialSearchViewModel.kt	Added validation method delegating to credential-specific use cases and state management for editing mode
ExternalCredentialSearchFragment.kt	Implemented UI logic for edit mode including validation-based icon enabling and text change listener
.editorconfig	Added ktlint rules for when-entry bracing, blank lines, backticked identifiers, and unused imports

[BurningAXE]

From UX side - maybe the checkbox should be disabled, too, when the number is not valid. Otherwise it's weird to verify an invalid number. But then you have to reset it after every edit and you get into a rabbit hole :)

[luhmirin-s]

+1 to all of Milen's comments

[alexandr-simprints]

Thanks for feedback! The checkbox is now disabled when the credential is being edited

checkbox.mp4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud