[MS-1376] Add a guard against a race condition in MatcherFragment

[BurningAXE]

JIRA ticket
Will be released in: 2026.2.0

Root cause analysis (for bugfixes only)

First known affected version: a very old one!?

• If matcher finishes while user has navigated to exit screen, exit result is delivered first and then the matcher result gets forwarded to the Orchestrator which expects AppResult and crashes

Notable changes

• Adds a guard to the matchResponse observer - if current destination is not MatcherFragment anymore - drop the result as the user has already navigated away

Testing guidance

• Trigger and identification (preferably with a large pool and/or just-in-time CoSync so you have time to react)
• Proceed through the steps
• When you reach the matching step press back to go to the exit screen
• Wait some time to give the matcher time to finish (monitor logcat if device is connected)
• Select an exit reason and submit
• App should return a refusal without KABOOM

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

Adds a navigation-state guard in MatchFragment to prevent delivering a match result after the user has navigated away (e.g., to the exit form), avoiding a crash in the Orchestrator caused by an unexpected result type/order.

Changes:

• Adds a NavController.currentDestination check before calling finishWithResult() for matchResponse.
• Documents the intent with an inline comment.

[Copilot]

LiveDataEventWithContentObserver calls getContentIfNotHandled() before entering this lambda, so when currentDestination is not matcherFragment the match result will be silently consumed (lost). This can leave the user stuck if they navigate to the exit form and then tap “continue/go back” (no submission): when they return to MatchFragment the match has finished but the result event can no longer be delivered. Consider observing the LiveDataEventWithContent directly and only calling getContentIfNotHandled() after verifying the destination (or otherwise buffering the result until the fragment is current again).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud