MS-856 Better alert screen tracking#1630
Merged
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
force-pushed
the
feature/MS-856-better-alert-screen-tracking
branch
from
c458372 to
095a7c9
Compare
BurningAXE
reviewed
Mar 30, 2026
| vm.saveAlertEvent(it) | ||
|
|
||
| // Report non-fatal to keep the logs for investigation. | ||
| // Called after saving the event to have the event ID in user properties for easier correlation. |
Contributor
There was a problem hiding this comment.
Since the event is saved in a coroutine, there isn't a guarantee that it has been completed by the time this is reached. Plus, this logic is better placed in the VM anyway. So, can we move in saveAlertEvent()?
Contributor
Author
There was a problem hiding this comment.
Yeah, I wanted it to be as close to the fragment as possible to have cleaner stack trace and I completely missed the launch part. Moved into the coroutine to ensure that ID is always tracked.
luhmirin-s
force-pushed
the
feature/MS-856-better-alert-screen-tracking
branch
from
095a7c9 to
1ba72eb
Compare
|
BurningAXE
approved these changes
Mar 30, 2026
Contributor
BurningAXE
left a comment
BurningAXE
left a comment
There was a problem hiding this comment.
Much simpler that we (or at least I) thought!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2026.2.0
Notable changes
I also have reviewed all of the cases where alert screen is triggered and it seems that if there is an exception, we are at least logging it. This additional dedicated exception should be simpler to trace across
Testing guidance
Additional work checklist