MS-621 Upgrades #96
Merged
MS-621 Upgrades #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luhmirin-s
commented
Aug 15, 2024
luhmirin-s
commented
- Added regression test cases to ensure that API does not change during refactoring
- Update build tooling to latest versions
- Translated all files to Kotlin with small changes to make the implementation more "kotlin-like"
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
bastien-micheau-simprints,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
force-pushed
the
feature/MS-621-upgrades
branch
from
6daa3f6 to
081e40a
Compare
meladRaouf
approved these changes
Aug 15, 2024
build.gradle
Outdated
| dependencies { | ||
| classpath "com.android.tools.build:gradle:7.4.0" | ||
| classpath "io.github.gradle-nexus:publish-plugin:1.3.0" | ||
| classpath "com.android.tools.build:gradle:8.3.2" |
Contributor
There was a problem hiding this comment.
Can you use the latest gradle version ?
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip | ||
| distributionPath=wrapper/dists | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip |
Contributor
There was a problem hiding this comment.
Also, here the wrapper version 8.7
| private val templates: MutableMap<FingerIdentifier, ByteArray> = mutableMapOf() | ||
| ) : Parcelable { | ||
|
|
||
| fun setTemplate(fingerId: FingerIdentifier, fingerTemplate: ByteArray) { |
Contributor
There was a problem hiding this comment.
What about face temeplates?
Contributor
Author
There was a problem hiding this comment.
Hmm, I just translated the code explicitly not changing the API.
I will add a subtask to add the face templates well for the "improvements" part
alexandr-simprints
approved these changes
Aug 15, 2024
…hange during refactoring
luhmirin-s
force-pushed
the
feature/MS-621-upgrades
branch
from
081e40a to
06b0b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.