Fixing that one bug for the new site layout -- tommy#22
Closed
tomaswolfgang wants to merge 152 commits intomasterfrom
Closed
Fixing that one bug for the new site layout -- tommy#22tomaswolfgang wants to merge 152 commits intomasterfrom
tomaswolfgang wants to merge 152 commits intomasterfrom
Conversation
copied code to execute at page load (in addition to the .change function)
Initial iteration in new landing page layout
Probably my best one so far The design is an addition to the current landing page
…into LandingPage
When any course is removed from the flowchart (in or out of the schedule) it appears back again in its previous position in the table through dynamic ajax call
…dStuff Removecoursecustomcourseandstuff
Made all complementary courses appear on the same modal with mdl tabs Adding complementary courses adds to selected semester!
Dynamically adds complementary/elective courses into semester Courses are removable/buttons work Reveal modal is centralized with tabs
Some styling for the add-course button -- STILL LOOKS WEIRD Put both Complementary and Elective courses on the same modal with different tabs Corrected issues with removing courses from exemption semester Animation after all req courses are moved into the schedule -- NOT DONE -- this will trigger the adding complementary courses tutorial complementary courses added now appear the correct color
Mini Tutorial appears after adding your last required course! (this will only happen once because required courses are not removable) Dynamic add course buttons on all the semesters are added on this transition. Adding semesters before transition doesn't have add courses and after there is add course option
I accidentally had an incorrect variable name! Also added a check if there exists complementary courses before adding them
Removed the required section at the very bottom Added a new required tab to the course modal ability to add required courses
NOTE: we need to expand how the complementary/elective courses are parsed (from the SET_TEXT_ENGLISH)
Tab is removed if it is empty Add button is centered and at the top for ease of access Add course button added to exemption semester Re-adds header and course if all courses in a single groups are added then a single one is removed
tabs now dynamically appear and disappear! disappear happens if the last course from a tab is added. appear happens when a course from tab that doesn't exist is removed from the schedule. Additionally, I minified some repetitive js code within the add course listener function. Specific groups will also appear and disappear in the same manner that tabs operate with respect to particular groups.
Required courses are now removable (they appear in a required tab in the modal after being removed)
Newaddcomplementarylayout
Collaborator
|
Lol you compared with master instead of Dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is