Integration of the Aspect Ratio component to the doc site and registry#96
Merged
aeroplaniko merged 3 commits intodevfrom Aug 29, 2025
Merged
Integration of the Aspect Ratio component to the doc site and registry#96aeroplaniko merged 3 commits intodevfrom
aeroplaniko merged 3 commits intodevfrom
Conversation
|
Someone is attempting to deploy this pull request to the Sitecore Technical Marketing Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
aeroplaniko
approved these changes
Aug 29, 2025
aeroplaniko
approved these changes
Aug 29, 2025
SC-vishathamarasinghe
pushed a commit
that referenced
this pull request
Nov 14, 2025
#96) * Added aspect ratio component * Added aspect ratio component to the index * Added aspect ratio definition to the registry.json --------- Co-authored-by: Muthula <muhtula.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented
aspect ratiocomponent in both the registry and demo directories.This adds consistent UI and demo usage for
aspect ratioacross the project.Changes
aspect ratiocomponent insrc/components/ui/aspect-ratio.tsxaspect ratioinsrc/app/demo/[name]/ui/aspect-ratio.tsxaspect ratiocomponent as a new item insrc/app/demo/[name]/index.tsxaspect ratiodefinition in./registry.jsonaspect ratiocomponent locallyNote
The
aspect ratiocomponent needs to be registered inregistry.json; as this component doesn't exist in the site or registry.