Skip to content

[nextjs] Fix scaffolding issues#2196

Merged
illiakovalenko merged 3 commits intodevfrom
bug/jss-9330-create-fix
Apr 23, 2026
Merged

[nextjs] Fix scaffolding issues#2196
illiakovalenko merged 3 commits intodevfrom
bug/jss-9330-create-fix

Conversation

@art-alexeyenko
Copy link
Copy Markdown
Contributor

Description / Motivation

react path in tsconfig should only be present for apps scaffolded in monorepo context.
That wasn't an issue before, but started doing a number now - this PR fixes it.

Testing Details

  • Unit Test Added
  • Manual Test/Other - scaffold, build app from local version of create-sitecore-jss

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Copy Markdown
Collaborator

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I added a missing changelog entry

@illiakovalenko illiakovalenko merged commit 160c9db into dev Apr 23, 2026
5 checks passed
@illiakovalenko illiakovalenko deleted the bug/jss-9330-create-fix branch April 23, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants