Skip to content

Fix Build Process.#138

Merged
JimBobSquarePants merged 6 commits intomasterfrom
js/fix-build
May 25, 2021
Merged

Fix Build Process.#138
JimBobSquarePants merged 6 commits intomasterfrom
js/fix-build

Conversation

@JimBobSquarePants
Copy link
Copy Markdown
Member

@JimBobSquarePants JimBobSquarePants commented May 25, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

There's something funny going on with versioning for .NET Core 3.1. See #137

I've checked and none of our other repositories are affected so I'm assuming (hoping) it's something to do with this repositories git history

Looking at the publish step there's a warning that the project directory is not a valid git folder. I'm going to see if simplifying the process to use standard action options fixes the issue.
https://github.com/SixLabors/ImageSharp.Drawing/runs/2644202851?check_suite_focus=true#step:5:82

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2021

Codecov Report

Merging #138 (8aafd9e) into master (eccffe8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          89       89           
  Lines        5142     5142           
  Branches     1051     1051           
=======================================
  Hits         3566     3566           
  Misses       1359     1359           
  Partials      217      217           
Flag Coverage Δ
unittests 69.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccffe8...8aafd9e. Read the comment docs.

@JimBobSquarePants
Copy link
Copy Markdown
Member Author

Ok... Versioning on build is correct but the only way to really test this (since I couldn't replicate it locally) is to merge to master and let publish run.

@JimBobSquarePants JimBobSquarePants merged commit 4f009c8 into master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant