Fix Build Process.#138
Merged
JimBobSquarePants merged 6 commits intomasterfrom May 25, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 89 89
Lines 5142 5142
Branches 1051 1051
=======================================
Hits 3566 3566
Misses 1359 1359
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Member
Author
|
Ok... Versioning on build is correct but the only way to really test this (since I couldn't replicate it locally) is to merge to master and let publish run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
There's something funny going on with versioning for .NET Core 3.1. See #137
I've checked and none of our other repositories are affected so I'm assuming (hoping) it's something to do with this repositories git history
Looking at the publish step there's a warning that the project directory is not a valid git folder. I'm going to see if simplifying the process to use standard action options fixes the issue.
https://github.com/SixLabors/ImageSharp.Drawing/runs/2644202851?check_suite_focus=true#step:5:82