Skip to content

ASTC decoding part 0: Test infrastructure improvements#45

Open
Erik-White wants to merge 8 commits into
SixLabors:mainfrom
Erik-White:test-infra-improvements
Open

ASTC decoding part 0: Test infrastructure improvements#45
Erik-White wants to merge 8 commits into
SixLabors:mainfrom
Erik-White:test-infra-improvements

Conversation

@Erik-White
Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This is the first step a series of PRs that will add ASTC decoding support. This fixes a couple of small test/build related issues and improves test related convenience methods.

Fixes:

  • Fix a race condition with file name collisions (caused DDS test failures around 75% of the time when run locally)
  • Correctly dispose images in tests
  • Suppress strong naming warning for interactive tests
  • Fix build paths for non-Windows systems

Improvements:

  • Standardize the existing KTX1 test to follow conventions and improve assertions
  • Support test data subdirectories (WithFileAttribute walks subdirs)
  • Add a new convenience method for comparing cubemap face (CompareFacesToReferenceOutput)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not new, just renamed from KtxDecoderTests.cs, but the test has been updated and improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant