Skip to content

Fixed IDisposable leaks in jpeg decoder test suite.#1974

Merged
JimBobSquarePants merged 1 commit intoSixLabors:masterfrom
br3aker:dp/jpeg-tests-leak-fix
Feb 3, 2022
Merged

Fixed IDisposable leaks in jpeg decoder test suite.#1974
JimBobSquarePants merged 1 commit intoSixLabors:masterfrom
br3aker:dp/jpeg-tests-leak-fix

Conversation

@br3aker
Copy link
Contributor

@br3aker br3aker commented Feb 2, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Some tests didn't dispose JpegDecoderCore instance thus leading to memory leaks. Well, not actual leaks but, you know, it's bad.

@br3aker br3aker changed the title IDisposable JpegDecoderCore is now properly disposed in tests Fixed IDisposable leaks in jpeg decoder test suite. Feb 2, 2022
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JimBobSquarePants JimBobSquarePants merged commit 414bbe2 into SixLabors:master Feb 3, 2022
@br3aker br3aker deleted the dp/jpeg-tests-leak-fix branch February 3, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants