Add AllocationTrackedMemoryManager and refactor allocators#3120
Open
JimBobSquarePants wants to merge 3 commits intomainfrom
Open
Add AllocationTrackedMemoryManager and refactor allocators#3120JimBobSquarePants wants to merge 3 commits intomainfrom
JimBobSquarePants wants to merge 3 commits intomainfrom
Conversation
JimBobSquarePants
added
breaking
Member
|
It would be very helpful for my review if we could revert #3056, and rebase this on top of the original state. I want to review the feature implementation as a whole thing and now it's difficult to react to specific changes from that PR. |
4 tasks
JimBobSquarePants
force-pushed
the
js/optimize-allocation-tracking
branch
from
127b5bb to
15fd941
Compare
Member
Author
|
#3056 has been reverted and this PR rebased over the top. Hopefully this is much easier to review now the diff is clean. |
Member
|
Thanks a lot! I'll come back to this once the Drawing API is concluded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
An updated implementation of #3056
@antonfirsov your comment in the PR was the key to a better implementation for me.
I was so determined not to make a breaking change that I massively overcomplicated the implementation and made it inefficient.
This PR changes things by implementing a new type
AllocationTrackedMemoryManagerwhich custom allocator memory managers must implement. By makingMemoryAllocator.Allocatenon virtual and adding an abstractAllocateCoreI can introduce tracking without the allocation and complexity cost.