Skip to content

Validate PBM max pixel value #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 1 commit into from
May 26, 2026
+18 −0
Merged

Validate PBM max pixel value #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ImageSharp/Formats/Pbm/PbmDecoderCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ private void ProcessHeader(BufferedReadStream stream)
ThrowPrematureEof();
}

if (this.maxPixelValue <= 0 || this.maxPixelValue >= 65536)
{
throw new InvalidImageContentException("Invalid max pixel value.");
}

if (this.maxPixelValue > 255)
{
this.componentType = PbmComponentType.Short;
Expand Down
13 changes: 13 additions & 0 deletions tests/ImageSharp.Tests/Formats/Pbm/PbmDecoderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,19 @@ public void PbmDecoder_Decode_Resize<TPixel>(TestImageProvider<TPixel> provider)
appendPixelTypeToFileName: false);
}

[Theory]
[InlineData("P2")]
[InlineData("P3")]
[InlineData("P5")]
[InlineData("P6")]
public void Decode_MaxPixelValueZero_ThrowsInvalidImageContentException(string magic)
{
byte[] bytes = Encoding.ASCII.GetBytes($"{magic} 1 1 0\n0");
using MemoryStream stream = new(bytes);

Assert.Throws<InvalidImageContentException>(() => Image.Load<Rgba32>(stream));
}

[Fact]
public void PlainText_PrematureEof()
{
Expand Down
Loading