Change while logic

[stefannikolei]

• need to be while(true) otherwise this leads to a early return

[JimBobSquarePants]

Amazing, I was looking everywhere else for the issue.

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

-- Leon Bambrick

[JimBobSquarePants]

@stefannikolei Looks like I've still got some debugging to do. Despite everything else being correct, there's a hole registered that shouldn't exist.

I've done a lot of cleanup in the repo code which should make things easier to debug if you fancy a pop.

[stefannikolei]

@JimBobSquarePants The js also has that hole

But it does some other things after connecting the edges

[stefannikolei]

@JimBobSquarePants I just looked deeper into the test code. I realised that the HoleCount will never be greater than 0. It is never set in ConvertToPolygon

Is the hole count interesting for the consumer at the end, or is it just an internal thing? Probably only the coordinates are from interest for the consumer? Or?

[JimBobSquarePants]

@JimBobSquarePants I just looked deeper into the test code. I realised that the HoleCount will never be greater than 0. It is never set in ConvertToPolygon

Is the hole count interesting for the consumer at the end, or is it just an internal thing? Probably only the coordinates are from interest for the consumer? Or?

I just this moment realised that!!

It should be something that is captured should the user be using different filling rules. NonZero expects CW for outer contours and CCW for inner holes. This seems like a massive oversite in the testing to me.