Skip to content

Conversation

@kstkn
Copy link

@kstkn kstkn commented May 12, 2020

No description provided.

@kstkn kstkn requested a review from zserge May 12, 2020 14:38
@kstkn
Copy link
Author

kstkn commented May 12, 2020

When checkout fails because cached repository doesn't have requested commit, we do pull, but still return the error because err is shadowed in the if block

@zserge zserge merged commit 5b9c401 into v3 May 13, 2020
@robodenitro robodenitro deleted the fix-err-shadowing branch May 27, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants