Skip to content

Enable DSL progress logging by default and add property tests#982

Merged
SkBlaz merged 5 commits intomasterfrom
copilot/update-dsl-progress-default
Jan 5, 2026
Merged

Enable DSL progress logging by default and add property tests#982
SkBlaz merged 5 commits intomasterfrom
copilot/update-dsl-progress-default

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 5, 2026

Issue requested progress logging enabled by default in DSL and property tests for coverage gaps.

Changes

Progress logging default

  • Changed progress parameter default from False to True in:
    • QueryBuilder.execute()
    • execute_ast(), _execute_windowed_query(), _execute_select()
  • Updated docstring examples to show disabling rather than enabling

Impact: Users see INFO-level progress messages by default. Opt-out with progress=False.

# Before: silent by default
result = Q.nodes().compute("degree").execute(network)

# After: progress shown by default  
result = Q.nodes().compute("degree").execute(network)
# INFO: Starting DSL query execution
# INFO: Step 1: Binding parameters
# ...

# Disable explicitly
result = Q.nodes().compute("degree").execute(network, progress=False)

Property-based tests

Added tests/test_dsl_properties.py with 19 Hypothesis-based tests covering:

  • Query builder API (limit, compute, chaining)
  • Condition construction and evaluation
  • Parameter binding validation
  • Query execution invariants
  • Result metadata consistency
  • Progress logging behavior

Uses categories instead of deprecated whitelist_categories in Hypothesis 6.x.

Original prompt

This section details on the original issue you should resolve

<issue_title>prop tests</issue_title>
<issue_description>Go over existing dsl, make sure progress is always enabled by default. Add prop tests where coverage lacks. nk new md allowed.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 4 commits January 5, 2026 03:32
Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure progress is enabled by default in DSL Enable DSL progress logging by default and add property tests Jan 5, 2026
Copilot AI requested a review from SkBlaz January 5, 2026 03:42
@SkBlaz SkBlaz marked this pull request as ready for review January 5, 2026 03:58
@SkBlaz SkBlaz merged commit 2964c16 into master Jan 5, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prop tests

2 participants