Andrii/sketch/refactor to jsx3 #314
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feihong
reviewed
Jan 9, 2022
Contributor
feihong
left a comment
feihong
left a comment
There was a problem hiding this comment.
Probably should add comment to ReactOld.re explaining that it's deprecated and will be deleted once JSX2 to JSX3 migration is completed
.idea/.gitignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Default ignored files | |||
Contributor
There was a problem hiding this comment.
@andrii-antiukhov Is it necessary to check these .idea files in?
Contributor
Author
There was a problem hiding this comment.
Sorry, i do not know. It was changed not by me, maybe it should not be in GIT, but for this we should exclude this files .idea from GIT in .gitignore , maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to JSX3